Bump to Go 1.24 and account for the new crypto/rand behaviour. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Go 1.24, Go itself aborts rather than return an error from `cryto/rand`. This means that the unit tests we have for this edge case abort immediately, and so this commit removes them. Several internal APIs no longer need to return errors as a result, either. Public APIs that return an error cannot be changed, but they now document when they will never do so. This commit also moves us to using Go's new `tools` directive, which should improve release automation since we no longer rely on folks to read the `Makefile` to figure out how to install the right helper binaries. Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Go 1.24, Go itself aborts rather than return an error from
cryto/rand. This means that the unit tests we have for this edge case abort immediately, and so this commit removes them.Several internal APIs no longer need to return errors as a result, either.
Public APIs that return an error cannot be changed, but they now document when they will never do so.
This commit also moves us to using Go's new
tooldirective, which should improve release automation since we no longer rely on folks to read theMakefileto figure out how to install the right helper binaries.