Add shiny:restyle event for listening to instances where session() updates stylesheet(s) #3301
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates stylesheet(s). Will be useful for real-time theming integration in flexdashboard rstudio/flexdashboard#308
wch
reviewed
Feb 22, 2021
| @@ -174,6 +174,9 @@ function renderDependency(dep) { | |||
| sheet.disabled = true; | |||
| if (browser.isIE) sheet.cssText = ""; | |||
| $(sheet.ownerNode).remove(); | |||
| $(document).trigger({ | |||
| type: 'shiny:restyle', oldSheet: sheet | |||
There was a problem hiding this comment.
Mainly so can get at the href so you which <link> was updated
There was a problem hiding this comment.
That being said, maybe we could add the name and version of the relevant HTML dependency
|
Just a note: we should also document this in the Shiny JS events article. |
|
Sorry, I was actually thinking of closing this on Friday since I found a way to do what I needed without this. That being said, I suppose this could maybe useful for something else at some point 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be useful for real-time theming integration in flexdashboard rstudio/flexdashboard#308