Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot outputs incorrectly sized inside scaled outputs #4139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Plot outputs incorrectly sized inside scaled outputs #4139

wants to merge 3 commits into from

Commits on Oct 1, 2024

  1. Fix #4135: Plot outputs incorrectly sized inside scaled outputs 

    CSS zoom property affects el.getBoundingClientRect() but not
el.offsetWidth/Height. When reporting sizes of outputs from
client to server, we need to back out the CSS zoom because
those sizes are used as CSS width/height, which will be
affected by zoom.

(Note that something similar happens with CSS transforms but
we don't have a good way to deal with them)
    @jcheng5
    jcheng5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7756678 View commit details
    Browse the repository at this point in the history

  2. Squelch TS error

    @jcheng5
    jcheng5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7cadc7a View commit details
    Browse the repository at this point in the history

  3. yarn build (GitHub Actions)

    @jcheng5
    jcheng5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    07ed184 View commit details
    Browse the repository at this point in the history