Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantastic, has bug (from WP.org) #176

Open
2 of 5 tasks
joelabreo227 opened this issue May 20, 2024 · 2 comments
Open
2 of 5 tasks

Fantastic, has bug (from WP.org) #176

joelabreo227 opened this issue May 20, 2024 · 2 comments
Assignees
Milestone

Comments

@joelabreo227
Copy link

joelabreo227 commented May 20, 2024

Original report: https://wordpress.org/support/topic/fantastic-has-bug/#new-post

Existing PR (potentially stale): #144

Tasks

Preview Give feedback
@joelabreo227
Copy link
Author

Changelog:

  • If the plugin setting is ON and the WP setting is OFF, Login with Google with still create a user.
    • Basically, there are two different user creation flows, our and WP core's and we're keeping them separate
  • When a user installs the plugin, the "register new user" will now be ON by default (since that's what the user installed the plugin to do, and presumably is expecting)
    • Existing users' install should NOT be affected

@SH4LIN
Copy link
Contributor

SH4LIN commented May 28, 2024

Remember me research: Find out how much WP Core defaults to.

WordPress core will set cookies for 14 days + 1 day when the remember me checkbox is checked.

image

1 day extra is the login grace period.

  • This expiry time can be modified using this filter auth_cookie_expiration

CC: @joelabreo227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants