Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Login redirection to Homepage instead of admin dashboard #177

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

SH4LIN
Copy link
Contributor

@SH4LIN SH4LIN commented May 29, 2024

Description

  • This PR will replace the redirect URL to home_url() if redirect_to query argument is empty.

Technical Implementation

  • Replaced the admin_url() with home_url() from the Login.php and OneTapLogin.php

Fixes/Covers

Pooja Killekar and others added 14 commits October 29, 2021 16:53
Update Readme.md & readme.txt with Tested upto 5.8.1 details
Sync Develop branch with master branch
* Fix: phpcs errors

1. Blank line after function.
2. Ignore WordPress.NamingConventions.ValidHookName.UseUnderscores because of backward compatibility

* Fix: phpcs error for equal sign alignment

* Fix: phpcs errors

1. Spacing and equal line alignement issue.
2. Ignore object param and return type because assuming php greater than 7.1 also requrires php 7.4 as plugin description.
3. Change CamelCase to snake_case variables.

* Fix: phpcs error for file /tests/bootstrap.php for spacing issue

* Fix: phpcs errors

1. Spacing and alignment issue.
2. Naming convention
3. Multiline array comma issue

* Fix issue added by bot for undefined variable

* Exclude hook name validation rule instead ignoring

* Update unit tests workflow

* Add slah before wp_json_encode function

* Revert json encode change
Feat: Add phpcs fixes and Update composer.json and vendor files
@SH4LIN SH4LIN changed the title Update: Login redirection to Homepage instead of Admin dashboard Update: Login redirection to Homepage instead of admin dashboard May 29, 2024
Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants