Update node version and NPM packages #78
+32,928
−15,606
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 16.17.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import '../src/styles/sass/styles.scss'; | ||
| import '../src/styles/vendor/bootstrap.min.css'; | ||
|
|
||
| export default function App({ Component, pageProps }) { | ||
| return <Component {...pageProps} />; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| // External. | ||
| import { useMutation } from '@apollo/client'; | ||
| import Link from 'next/link'; | ||
| import Router from 'next/router'; | ||
| import { useState } from 'react'; | ||
|
|
||
| // Internal. | ||
| import client from '../src/apollo/ApolloClient'; | ||
| import Layout from '../src/components/layouts/Layout'; | ||
| import Loading from '../src/components/message-alert/Loading'; | ||
| import MessageAlert from '../src/components/message-alert/MessageAlert'; | ||
| import { LOGIN_USER } from '../src/queries'; | ||
| import { isUserValidated } from '../src/utils/auth-functions'; | ||
| import isEmpty from '../src/validator/isEmpty'; | ||
| import validateAndSanitizeLoginForm from '../src/validator/login'; | ||
| /** | ||
| * Login functional component. | ||
| * | ||
|
|
@@ -145,14 +148,9 @@ const Login = () => { | |
| } | ||
| }; | ||
|
|
||
| const [login, { loading: loading }] = useMutation(LOGIN_USER, { | ||
| client | ||
| }); | ||
|
There was a problem hiding this comment. @Souptik2001 Let's break it into multiple lines to make it more readable There was a problem hiding this comment. @imranhsayed As per the current prettier configuration, as this line doesn't exceed a threshold line length limit, that's why it is showing error if we are breaking this line. So, should we change that configuration, because otherwise there will be linting error. There was a problem hiding this comment. Yes please. let's update the configuration to make it look more readable @Souptik2001 |
||
|
|
||
| return ( | ||
| <Layout> | ||
|
|
@@ -163,12 +161,12 @@ const Login = () => { | |
| {/* Error Message */} | ||
| {'' !== errorMessage | ||
| ? showAlertBar && ( | ||
| <MessageAlert | ||
| message={errorMessage} | ||
| success={false} | ||
| onCloseButtonClick={onCloseButtonClick} | ||
| /> | ||
| ) | ||
| : ''} | ||
|
|
||
| {/* Login Form */} | ||
|
|
@@ -177,7 +175,7 @@ const Login = () => { | |
| <div className="form-group"> | ||
| <label className="lead mt-1" htmlFor="username-or-email"> | ||
| Username or email | ||
| </label> | ||
| <input | ||
| type="text" | ||
| className="form-control" | ||
|
|
@@ -192,7 +190,7 @@ const Login = () => { | |
| <div className="form-group"> | ||
| <label className="lead mt-1" htmlFor="password"> | ||
| Password | ||
| </label> | ||
| <input | ||
| type="password" | ||
| className="form-control" | ||
|
|
@@ -210,9 +208,9 @@ const Login = () => { | |
| disabled={loading ? 'disabled' : ''} | ||
| type="submit"> | ||
| Login | ||
| </button> | ||
| <Link className="btn btn-secondary ml-2" href="/register"> | ||
| Register | ||
| </Link> | ||
| </div> | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Souptik2001 Let's segregate these with comments, Internal dependencies and external dependencies resp. Lets do that where applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imranhsayed Just to be once confirmed you meant like this right? -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly @Souptik2001 Looks more organised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Souptik2001 When we assign the issue back for review, it's the reviewer who will mark the comments resolved after checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Souptik2001 Let's rename the comments to
Internal DependenciesandExternal Dependenciesrespectively.