Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load less of minitest in the test support file #328

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bquorning
Copy link
Contributor

@bquorning bquorning commented Jan 28, 2025

Allow other projects to load "rubocop/minitest/support" without opting in to "minitest/autorun" and 'minitest/pride'.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bquorning bquorning force-pushed the smaller-minitest-support-file branch from db8b7c6 to de2bb48 Compare January 28, 2025 22:03
@bquorning bquorning marked this pull request as ready for review January 28, 2025 22:03
@bquorning bquorning requested a review from koic January 28, 2025 22:03
CHANGELOG.md Outdated Show resolved Hide resolved
@bquorning bquorning force-pushed the smaller-minitest-support-file branch from de2bb48 to 530813e Compare February 4, 2025 07:38
Allow other projects to load "rubocop/minitest/support" without opting
in to "minitest/autorun" and 'minitest/pride'.
@bquorning bquorning force-pushed the smaller-minitest-support-file branch from 530813e to 0f34ea4 Compare February 4, 2025 07:52
@koic koic merged commit 5d3545a into master Feb 4, 2025
15 checks passed
@bquorning bquorning deleted the smaller-minitest-support-file branch February 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants