Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for RSpecRails/HttpStatus #1849

Closed
wants to merge 1 commit into from
Closed

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 29, 2024

Fix: rubocop/rubocop-rspec_rails#9


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@Strech
Copy link

Strech commented Mar 29, 2024

I'm confused with a new set of dependencies, why rubocop-rspec depends on rubocop-rspec_rails when rspec is completely independent of Rails?

@ydah ydah closed this Mar 29, 2024
@ydah
Copy link
Member Author

ydah commented Mar 29, 2024

This was temporarily revived, so close it.

@ydah ydah deleted the fix-error-rspec_rails branch March 29, 2024 22:39
@ydah
Copy link
Member Author

ydah commented Mar 29, 2024

I'm confused with a new set of dependencies, why rubocop-rspec depends on rubocop-rspec_rails when rspec is completely independent of Rails?

For backward compatibility. The next major version will be completely independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants