Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flaky test for spec/project/default_config_spec.rb #1855

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 31, 2024

bundle exec rspec './spec/project/default_config_spec.rb[1:8]' './spec/rubocop/rspec/description_extractor_spec.rb[1:1]' --seed=28987

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

```
bundle exec rspec './spec/project/default_config_spec.rb[1:8]' './spec/rubocop/rspec/description_extractor_spec.rb[1:1]' --seed=28987
```
@ydah ydah requested a review from a team as a code owner March 31, 2024 00:03
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydah ydah merged commit 954b29e into master Mar 31, 2024
24 checks passed
@ydah ydah deleted the fix-flaky branch March 31, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants