Skip to content

Commit

Permalink
Merge pull request #48 from Billiam/bugfix/no-default-add-module
Browse files Browse the repository at this point in the history
Remove default `add_module` for passkey strategy
  • Loading branch information
tcannonfodder authored Aug 19, 2023
2 parents 849f2dd + 854d36c commit 6940cc5
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## [0.3.0] - 2023-08-18

### Bugfixes

- Remove default `Devise.add_module`, remove incorrect `no_input: true` declaration in documentation
- https://github.com/ruby-passkeys/devise-passkeys/pull/48

## [0.2.0] - 2023-07-07

### Bugfixes
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ Devise.add_module :passkey_authenticatable,
model: 'devise/passkeys/model',
route: {session: [nil, :new, :create, :destroy] },
controller: 'controller/sessions',
strategy: true,
no_input: true
strategy: true
```

# FAQs
Expand Down
5 changes: 0 additions & 5 deletions lib/devise/passkeys.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,3 @@ def self.create_and_return_passkey(resource:, label:, webauthn_credential:, extr
end
end
end

Devise.add_module :passkey_authenticatable,
model: "devise/passkeys/model",
strategy: true,
no_input: true
2 changes: 1 addition & 1 deletion lib/devise/passkeys/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Devise
module Passkeys
VERSION = "0.2.0"
VERSION = "0.3.0"
end
end

0 comments on commit 6940cc5

Please sign in to comment.