Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a warning: the block passed to 'map_type_name' .. may be ignored #2248

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

mame
Copy link
Member

@mame mame commented Jan 21, 2025

Fixes #2247

Copy link
Contributor

@ParadoxV5 ParadoxV5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow you’re fast 🤠.

Comment on lines +232 to 234
def map_type_name(&)
ClassSingleton.new(
name: yield(name, location, self),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def map_type_name(&)
ClassSingleton.new(
name: yield(name, location, self),
def map_type_name(&blk)
ClassSingleton.new(
name: blk.(name, location, self),

@soutaro soutaro added this to the RBS 3.9 milestone Jan 24, 2025
@soutaro soutaro enabled auto-merge January 24, 2025 02:18
@soutaro soutaro added this pull request to the merge queue Jan 24, 2025
Merged via the queue into ruby:master with commit 0c70720 Jan 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix map type name warnings due to unused block
3 participants