Merge branch 'master' into update_rdoc_document_heading_levels

ruby · Oct 7, 2024 · 9f2e1b1 · 9f2e1b1
2 parents b4b492c + b53f0cb
commit 9f2e1b1
Show file tree

Hide file tree

Showing 8 changed files with 69 additions and 9 deletions.
diff --git a/lib/rdoc/generator/template/darkfish/css/rdoc.css b/lib/rdoc/generator/template/darkfish/css/rdoc.css
@@ -92,7 +92,6 @@ h6:target {
   color: var(--link-color);
   text-decoration: none;
   transition: color 0.3s ease;
-  font-weight: 600;  /* Make links bolder */
 }
 
 :link:hover,

diff --git a/lib/rdoc/markup/to_rdoc.rb b/lib/rdoc/markup/to_rdoc.rb
@@ -249,8 +249,8 @@ def accept_verbatim verbatim
   # Adds +table+ to the output
 
   def accept_table header, body, aligns
-    widths = header.zip(body) do |h, b|
-      [h.size, b.size].max
+    widths = header.zip(*body).map do |cols|
+      cols.map(&:size).max
     end
     aligns = aligns.map do |a|
       case a
@@ -262,12 +262,12 @@ def accept_table header, body, aligns
         :rjust
       end
     end
-    @res << header.zip(widths, aligns) do |h, w, a|
+    @res << header.zip(widths, aligns).map do |h, w, a|
       h.__send__(a, w)
     end.join("|").rstrip << "\n"
     @res << widths.map {|w| "-" * w }.join("|") << "\n"
     body.each do |row|
-      @res << row.zip(widths, aligns) do |t, w, a|
+      @res << row.zip(widths, aligns).map do |t, w, a|
         t.__send__(a, w)
       end.join("|").rstrip << "\n"
     end

diff --git a/test/rdoc/support/text_formatter_test_case.rb b/test/rdoc/support/text_formatter_test_case.rb
@@ -99,6 +99,23 @@ def test_accept_paragraph_wrap
         accept_paragraph_wrap
       end
 
+      ##
+      # Test case that calls <tt>@to.accept_table</tt>
+
+      def test_accept_table_align
+        header = ['AA', 'BB', 'CCCCC']
+        body = [
+          ['', 'bbb', 'c'],
+          ['aaaa', 'b', ''],
+          ['a', '', 'cc']
+        ]
+        aligns = [nil, :left, :right]
+        @to.start_accepting
+        @to.accept_table header, body, aligns
+
+        accept_table_align
+      end
+
       ##
       # Test case that calls <tt>@to.attributes</tt> with an escaped
       # cross-reference.  If this test doesn't pass something may be very

diff --git a/test/rdoc/test_rdoc_markup_to_ansi.rb b/test/rdoc/test_rdoc_markup_to_ansi.rb
@@ -348,6 +348,17 @@ def list_verbatim
     assert_equal expected, @to.end_accepting
   end
 
+  def accept_table_align
+    expected = "\e[0m" + <<-EXPECTED
+ AA |BB |CCCCC
+----|---|-----
+    |bbb|    c
+aaaa|b  |
+ a  |   |   cc
+    EXPECTED
+    assert_equal expected, @to.end_accepting
+  end
+
   # functional test
   def test_convert_list_note
     note_list = <<-NOTE_LIST

diff --git a/test/rdoc/test_rdoc_markup_to_bs.rb b/test/rdoc/test_rdoc_markup_to_bs.rb
@@ -349,4 +349,15 @@ def list_verbatim
     assert_equal expected, @to.end_accepting
   end
 
+  def accept_table_align
+    expected = <<-EXPECTED
+ AA |BB |CCCCC
+----|---|-----
+    |bbb|    c
+aaaa|b  |
+ a  |   |   cc
+    EXPECTED
+    assert_equal expected, @to.end_accepting
+  end
+
 end
diff --git a/test/rdoc/test_rdoc_markup_to_markdown.rb b/test/rdoc/test_rdoc_markup_to_markdown.rb
@@ -346,6 +346,17 @@ def list_verbatim
     assert_equal expected, @to.end_accepting
   end
 
+  def accept_table_align
+    expected = <<-EXPECTED
+ AA |BB |CCCCC
+----|---|-----
+    |bbb|    c
+aaaa|b  |
+ a  |   |   cc
+    EXPECTED
+    assert_equal expected, @to.end_accepting
+  end
+
   def test_convert_RDOCLINK
     result = @to.convert 'rdoc-garbage:C'
 

diff --git a/test/rdoc/test_rdoc_markup_to_rdoc.rb b/test/rdoc/test_rdoc_markup_to_rdoc.rb
@@ -346,6 +346,17 @@ def list_verbatim
     assert_equal expected, @to.end_accepting
   end
 
+  def accept_table_align
+    expected = <<-EXPECTED
+ AA |BB |CCCCC
+----|---|-----
+    |bbb|    c
+aaaa|b  |
+ a  |   |   cc
+    EXPECTED
+    assert_equal expected, @to.end_accepting
+  end
+
   # functional test
   def test_convert_list_note
     note_list = <<-NOTE_LIST

diff --git a/test/rdoc/test_rdoc_ri_driver.rb b/test/rdoc/test_rdoc_ri_driver.rb
@@ -54,10 +54,10 @@ def test_self_dump
       RDoc::RI::Driver.dump @store1.cache_path
     end
 
-    assert_match %r%:class_methods%,    out
-    assert_match %r%:modules%,          out
-    assert_match %r%:instance_methods%, out
-    assert_match %r%:ancestors%,        out
+    assert_match %r%:class_methods|class_methods:%,       out
+    assert_match %r%:modules|modules:%,                   out
+    assert_match %r%:instance_methods|instance_methods:%, out
+    assert_match %r%:ancestors|ancestors:%,               out
   end
 
   def test_add_also_in_empty