Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar scroll again and add missing footer back #1154

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 15, 2024

  1. In Fix sidebar scroll and footer display #1152 I only added footer to index.html but forgot about other pages. So I added it back to them in this PR.
  2. I standardized sidebar nav's structure to be:
    <nav id="navigation" role="navigation">
      <div id="project-navigation">
        <%= render '_sidebar_navigation.rhtml' %>
        <%= render '_sidebar_search.rhtml' %>
      </div>
      <!-- if the page originally has it -->
      <%= render '_sidebar_table_of_contents.rhtml' %>
    
      <!-- sidebar content for the page -->
    
      <%= render '_footer.rhtml' %>
    </nav>
    And removed unnecessary divs like #project-metadata or #class-metadata as they were never referenced
  3. I changed nav's default overflow setting to auto so we don't need to make individual elements to be scrollable.

Demo

Screen.Recording.2024-08-15.at.12.55.56.mov

In #1152 the footer partial was only added to the index.rhtml file.
This commit adds the footer partial to the other template files.
Because sidebar needs to be scrollable, its overflow should default to auto.
Currently it's set to hidden and force individual elements to set overflow auto,
which overcomplicates things.
@st0012 st0012 merged commit b8c2bcd into master Aug 15, 2024
51 checks passed
@st0012 st0012 deleted the fix-sidebar-scroll-2 branch August 15, 2024 13:31
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 15, 2024
(ruby/rdoc#1154)

* Add missing footers

In #1152 the footer partial was only added to the index.rhtml file.
This commit adds the footer partial to the other template files.

* Remove unnecessary middle divs in nav

* Simplify sidebar's overflow settings

Because sidebar needs to be scrollable, its overflow should default to auto.
Currently it's set to hidden and force individual elements to set overflow auto,
which overcomplicates things.

ruby/rdoc@b8c2bcd8db
@st0012 st0012 added the bug label Aug 15, 2024
@st0012 st0012 added this to the v6.8.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants