Tilde should not be escaped as per RFC3986 #117
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first time contributing so sorry if I'm missing anything!
Issue
Heads up
This might be a breaking change, since some server-client setup might rely on
~
being encoded to%7E
for whatever reason.But since this is an RFC offense, the proposed implementation should be the way to go and must be enforced for future usage in web interactive applications and such.
Decoding
~
must remain the same, we just don't want to encode~
.Details
This PR's change follows other escaping methods in core Ruby, such as
CGI.escape
,ERB::Util.url_encode
(which actually just callsCGI.escapeURIComponent
inside).