Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape reserved characters in scheme name #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nobu
Copy link
Member

@nobu nobu commented Jan 23, 2025

Fix #89

nobu added 2 commits January 23, 2025 21:19
TruffleRuby does not allow Symbol categories as identifiers.
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny spelling detail.


def register(name, klass)
unless scheme = escape(name)
raise ArgumentError, "invalid characater as scheme - #{name}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ArgumentError, "invalid characater as scheme - #{name}"
raise ArgumentError, "invalid character as scheme - #{name}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

register_scheme does not comply with rfc2396 (or 3986)
2 participants