Add parsing without raising exceptions #149
Open
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what Integer(value, exception: false) does but for
URI.parse(value, exception: false).
The change is implemented for the default parser (RFC3986) and also
RFC2396.
The goal is to allow parsing invalid/user input without having to have
control flow via exceptions or by having to wrap URI.parse in a method
per project.
This change can be tried via`~/.rubies/ruby-master/bin/ruby -r 'uri' -e
'URI.parse("https://example.com/\[\]", exception: false)'` and
`~/.rubies/ruby-master/bin/ruby -r 'uri' -e
'URI.parse("https://example.com/\[\]")'` respectively (or
with`exception: true`) and is also covered by tests.
Or by just changing the tests to observe the behavior
|
@nobu any chance you could approve the workflow run when you have some time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what Integer(value, exception: false) does but for
URI.parse(value, exception: false).
The change is implemented for the default parser (RFC3986) and also RFC2396.
The goal is to allow parsing invalid/user input without having to have control flow via exceptions or by having to wrap URI.parse in a method per project.
This change can be tried via
~/.rubies/ruby-master/bin/ruby -r 'uri' -e 'URI.parse("https://example.com/\[\]", exception: false)'and~/.rubies/ruby-master/bin/ruby -r 'uri' -e 'URI.parse("https://example.com/\[\]")'respectively (or withexception: true) and is also covered by tests.Or by just changing the tests to observe the behavior