Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid defining Hash#deep_merge and #deep_merge! #342

Merged

Commits on Oct 3, 2023

  1. Avoid defining Hash#deep_merge and #deep_merge!

    `config` uses `DeepMerge.deep_merge!` instead of `Hash#deep_merge!`, so
    monkey patching `Hash` is unnecessary.  Furthermore, DeepMerge's `Hash`
    monkey patch is not compatible with Rails 7.1 (see [rails#49457][]).
    
    This commit changes `require 'deep_merge'` to `require 'deep_merge/core'`
    so that DeepMerge's `Hash` monkey patch is no longer loaded.  Users who
    rely on the monkey patch can load it manually via
    `require 'deep_merge/deep_merge_hash'`.
    
    Closes rubyconfig#314.
    
    [rails#49457]: rails/rails#49457
    jonathanhefner committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    4a0b7a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    4a79eac View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    be234a9 View commit details
    Browse the repository at this point in the history