Merge pull request #35 from rubydevi/f/iterations-tests

Changes Requested:Readme:correct test command

.rubocop.yml

@@ -11,7 +11,7 @@ AllCops:
   DisplayCopNames: true
 
 Layout/LineLength:
-  Max: 120
+  Max: 125
 Metrics/MethodLength:
   Include:
     - 'app/controllers/*'
@@ -59,4 +59,4 @@ Style/HashEachMethods:
 Style/HashTransformKeys:
   Enabled: false
 Style/HashTransformValues:
-  Enabled: false
+  Enabled: false

Gemfile

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 ruby '3.2.2'
 
 # Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
+gem 'faker', '~> 2.20'
 gem 'rails', '~> 7.1.1'
 gem 'rspec-rails'
 gem 'rswag'

Gemfile.lock

@@ -115,6 +115,8 @@ GEM
       concurrent-ruby (~> 1.0)
       zeitwerk (~> 2.6)
     erubi (1.12.0)
+    faker (2.23.0)
+      i18n (>= 1.8.11, < 2)
     globalid (1.2.1)
       activesupport (>= 6.1)
     i18n (1.14.1)
@@ -276,6 +278,7 @@ DEPENDENCIES
   devise
   devise-jwt
   dotenv-rails
+  faker (~> 2.20)
   jsonapi-serializer
   pg (~> 1.1)
   puma (>= 5.0)

README.md

@@ -160,6 +160,12 @@ To run the project, you will need to execute:
 ```sh
   rails credentials:edit
 
+  rails db:create
+
+  rails db:migrate
+
+  rails db:seed
+
   rails s
 ```
 
@@ -168,7 +174,7 @@ To run the project, you will need to execute:
 To run tests, run the following command:
 
 ```sh
-  Rspec spec  or bundle exec rspec spec
+  rspec spec/model/
 ```
 
 <!-- ### Deployment

app/controllers/api/v1/reservations_controller.rb

@@ -35,7 +35,11 @@ def update
 
   # DELETE /reservations/1
   def destroy
-    @reservation.destroy!
+    if @reservation.destroy!
+      render json: { message: 'Reservation deleted successfully' }, status: :no_content
+    else
+      render json: { error: 'Failed to delete Reservation' }, status: :unprocessable_entity
+    end
   end
 
   private

app/controllers/reservations_controller.rb

@@ -33,11 +33,6 @@ def update
     end
   end
 
-  # DELETE /reservations/1
-  def destroy
-    @reservation.destroy!
-  end
-
   private
 
   # Use callbacks to share common setup or constraints between actions.

package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "react-hot-toast": "^2.4.1"
+  }
+}

spec/model/aeroplane_spec.rb

@@ -0,0 +1,76 @@
+require 'rails_helper'
+
+RSpec.describe Aeroplane, type: :model do
+  describe 'validations' do
+    it 'name should be present' do
+      aeroplane = Aeroplane.new(model: '[email protected]',
+                                image: 'image 1',
+                                description: 'Description of the planes',
+                                number_of_seats: 6,
+                                location: 'Middle Earth',
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'model should be present' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                image: 'image 1',
+                                description: 'Description of the planes',
+                                number_of_seats: 6,
+                                location: 'Middle Earth',
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'image should be present' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                model: 'Jet',
+                                description: 'Description of the planes',
+                                number_of_seats: 6,
+                                location: 'Middle Earth',
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'description should be present' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                image: 'image 1',
+                                model: 'Jet',
+                                number_of_seats: 6,
+                                location: 'Middle Earth',
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'number_of_seats should be present' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                image: 'image 1',
+                                model: 'Jet',
+                                description: 'Description of the planes',
+                                location: 'Middle Earth',
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'location should be present' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                image: 'image 1',
+                                model: 'Jet',
+                                description: 'Description of the planes',
+                                number_of_seats: 6,
+                                fee: 60.0)
+      expect(aeroplane).to_not be_valid
+    end
+
+    it 'fee should be greater than 0' do
+      aeroplane = Aeroplane.new(name: 'Dragon 1',
+                                image: 'image 1',
+                                model: 'Jet',
+                                description: 'Description of the planes',
+                                number_of_seats: 6,
+                                location: 'Middle Earth',
+                                fee: -1)
+      expect(aeroplane).to_not be_valid
+    end
+  end
+end

spec/model/reservations_spec.rb

@@ -0,0 +1,40 @@
+require 'rails_helper'
+
+RSpec.describe Reservation, type: :model do
+  let(:user) do
+    User.new(name: 'bob', email: '[email protected]', password: 'password12', password_confirmation: 'password12')
+  end
+  before { user.save }
+
+  let(:plane) do
+    Aeroplane.new(name: 'boning 777', model: '[email protected]', image: 'image 1', description: 'Description of the planes',
+                  number_of_seats: 6, location: 'Middle Earth', fee: 60.0)
+  end
+  before { plane.save }
+  let(:reservation) do
+    Reservation.new(reserved_date: '2023-11-11', start_time: '18:24', end_time: '20:25', start_location: 'addis ababa',
+                    destination: 'india', user_id: user.id, aeroplane_id: plane.id)
+  end
+  before { reservation.save }
+  context 'when testing the Reservation class' do
+    it 'should have user ' do
+      reservation.user_id = nil
+      expect(reservation).to_not be_valid
+    end
+    it 'should have areoplane ' do
+      reservation.aeroplane_id = nil
+      expect(reservation).to_not be_valid
+    end
+    it 'should have resevation date ' do
+      reservation.destination = nil
+      expect(reservation).to_not be_valid
+    end
+    it 'should have destination ' do
+      reservation.reserved_date = nil
+      expect(reservation).to_not be_valid
+    end
+    it 'should have pass if all valid ' do
+      expect(reservation).to be_valid
+    end
+  end
+end

swagger/v1/swagger.yaml

@@ -159,7 +159,7 @@ paths:
               - user_id
               - aeroplane_id
 servers:
-- url: http://{defaultHost}
+- url: https://{defaultHost}
   variables:
     defaultHost:
-      default: localhost:4000
+      default: http://127.0.0.1:4000/