Fix build and setup #83
Conversation
| @@ -14,8 +14,6 @@ ENV BUNDLE_JOBS 8 | |||
| ENV APP_HOME /myapp | |||
|
|
|||
| ARG RAILS_ENV=production | |||
| ENV RAILS_ENV=$RAILS_ENV | |||
| ENV RACK_ENV=$RAILS_ENV | |||
There was a problem hiding this comment.
arg is only available during build, but having those two envs here makes them permanent.
This can have an undesired effect in the test environment. In my testings, having those two lines make the test environment use the development database. Which is not a problem because everything runs inside a transaction but it is not ideal.
@parndt, please make sure you have both of them in fly ✌️
There was a problem hiding this comment.
Actually, I take it back. I don't think my test environment was using development database because of these two lines.
Yet, I don't think it is a good idea to have the two envs because it makes them permanent.
| To run the tests: | ||
|
|
||
| docker compose run --rm app bundle exec rspec | ||
|
|
There was a problem hiding this comment.
Appreciate if anyone can review English and if it is easy to understand 🤗.
|
Hello @parndt 👋, have you had time to look at this? Let me know if you won't have time, I can ping someone else ;) |
sometime "soon"*! |
This PR:
README.mdusing dockerI started fixing our build, but then I went down the rabbit hole fixing the docker setup as well. If needed let me know I can split this into two PRs.