Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all]: optional image registry #233

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

lobis
Copy link
Contributor

@lobis lobis commented Feb 24, 2025

Closes #232

This PR adds the option to specify an image registry which will be used to pull images. This is useful for example to avoid rate limiting from docker.io.

Currently the charts have dependence on other images, in many cases these can be specified via the image: so technically we already support registry usage, we just need to update the image url to include the registry. In some cases however the image is not exposed to the user (such as busybox in the webui). This makes it impossible for the user to configure a registry for this image, which may result in a rate limit block.

This PR adds an optional configuration, imageRegistry which defaults to "" and can point to a given registry e.g. registry.cern.ch/docker.io. If this option is set then all images used by the chart will be prepended this registry, even those that can be set manually by users.

Example usage:

  imageRegistry: registry.cern.ch/docker.io

  image:
    repository: rucio/rucio-server
    tag: release-36.2.0

All images, including rucio/rucio-server will be preprended the registry. This also applies to "hidden" dependencies such as busybox, apache, etc.

@lobis lobis force-pushed the 232-image-registry branch 2 times, most recently from f1833d2 to 2bc43af Compare February 24, 2025 09:58
@lobis lobis requested review from bari12 and rdimaio February 24, 2025 10:18
@lobis lobis marked this pull request as ready for review February 24, 2025 10:18
@lobis lobis force-pushed the 232-image-registry branch from 383a4b7 to 628179a Compare February 25, 2025 10:19
@bari12 bari12 merged commit b1bd510 into rucio:master Feb 25, 2025
1 check passed
@lobis lobis deleted the 232-image-registry branch February 25, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow optional usage of image registry
3 participants