Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232
This PR adds the option to specify an image registry which will be used to pull images. This is useful for example to avoid rate limiting from
docker.io
.Currently the charts have dependence on other images, in many cases these can be specified via the
image:
so technically we already support registry usage, we just need to update the image url to include the registry. In some cases however the image is not exposed to the user (such asbusybox
in thewebui
). This makes it impossible for the user to configure a registry for this image, which may result in a rate limit block.This PR adds an optional configuration,
imageRegistry
which defaults to""
and can point to a given registry e.g.registry.cern.ch/docker.io
. If this option is set then all images used by the chart will be prepended this registry, even those that can be set manually by users.Example usage:
All images, including
rucio/rucio-server
will be preprended the registry. This also applies to "hidden" dependencies such as busybox, apache, etc.