Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for multiple instance #458

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

pallabmaiti
Copy link
Contributor

@pallabmaiti pallabmaiti commented Feb 4, 2024

Description

Feature

Support for multiple instances with Unit Tests.

New Unit Tests added for:

  • EventFiltering
  • UserSession
  • ReplayQueue
  • Storage
  • Logger

@pallabmaiti pallabmaiti force-pushed the feature/sdk-431-support-multiple-instances branch 2 times, most recently from 16f8398 to 9c084e7 Compare February 7, 2024 12:02
@pallabmaiti pallabmaiti self-assigned this Feb 7, 2024
@pallabmaiti pallabmaiti requested a review from desusai7 February 7, 2024 12:14
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
61.4% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud

@pallabmaiti pallabmaiti marked this pull request as ready for review February 7, 2024 12:38
@pallabmaiti pallabmaiti requested a review from itsdebs as a code owner February 7, 2024 12:38
@pallabmaiti pallabmaiti added the v2 label Feb 14, 2024
@pallabmaiti pallabmaiti force-pushed the feature/sdk-1143-refactoring-work branch from 72be93b to af4afe6 Compare February 20, 2024 05:44
@pallabmaiti pallabmaiti force-pushed the feature/sdk-431-support-multiple-instances branch from 9c084e7 to d2118c4 Compare February 20, 2024 06:01
@pallabmaiti pallabmaiti changed the base branch from feature/sdk-1143-refactoring-work to develop-v3 February 20, 2024 06:01
…v2. (#477)

* chore: removed the responsibility of determining if migration is required from SourceConfigDownloader

* chore: removed the support for customizing the storage migrator by the users

* fix: moved the logic to determine if migration is needed to individual migrators

* test: added test for checking migration to handle all the cases

* chore: fixed issues with merge conflicts
@ChryssaAliferi ChryssaAliferi self-requested a review March 28, 2024 11:53
Copy link

sonarqubecloud bot commented Apr 4, 2024

@desusai7 desusai7 merged commit 525bb12 into develop-v3 Apr 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants