Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alias api with previousId support #554

Merged
merged 11 commits into from
Dec 9, 2024
Merged

feat: add alias api with previousId support #554

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e96188c
chore: update podfile.lock
1abhishekpandey Nov 26, 2024
61a67e9
fix: set previousId as anonmousId in alias API if userId is not present
1abhishekpandey Nov 26, 2024
92e80fd
Revert "chore: update podfile.lock"
1abhishekpandey Nov 26, 2024
7e375ca
feat: add alias api with previousId support
1abhishekpandey Nov 30, 2024
ed0cf71
feat: add new alias api in header file
1abhishekpandey Nov 30, 2024
773bad2
refactor: address comment
1abhishekpandey Dec 2, 2024
da7851d
Merge remote-tracking branch 'origin/fix/sdk-2669-ios-fix-alias-api' …
1abhishekpandey Dec 2, 2024
0e82ed6
Merge branch 'develop' into feat/sdk-2669-add-previousId-support-in-a…
1abhishekpandey Dec 6, 2024
f8b1e87
fix: update Alias API by having previousId filed in the middle
1abhishekpandey Dec 9, 2024
58c93b1
chore: fix alias api in RSClient.h
1abhishekpandey Dec 9, 2024
6e15f48
Merge remote-tracking branch 'origin/develop' into feat/sdk-2669-add-…
1abhishekpandey Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Classes/Headers/Public/RSClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ typedef void (^Callback)(NSObject *_Nullable);
- (void) group:(NSString *)groupId traits:(NSDictionary<NSString*, id>*)traits;
- (void) group:(NSString *)groupId;

- (void) alias:(NSString *)newId options:(RSOption * _Nullable) options previousId:(NSString * _Nullable)previousId;
- (void) alias:(NSString *)newId options:(RSOption * _Nullable) options;
- (void) alias:(NSString *)newId;

Expand Down
11 changes: 6 additions & 5 deletions Sources/Classes/RSClient.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,21 +225,22 @@ - (void)alias:(NSString *)newId {
[self reportDiscardedEvent];
return;
}
[self alias:newId options:nil];
[self alias:newId options:nil previousId:nil];
}

- (void) alias:(NSString *)newId options:(RSOption *) options {
[self alias:newId options:options previousId:nil];
}

- (void) alias:(NSString *)newId options:(RSOption *) options previousId:(NSString *)previousId {
if ([RSClient getOptStatus]) {
[self reportDiscardedEvent];
return;
}
RSContext *rc = [RSElementCache getContext];
NSMutableDictionary<NSString*,NSObject*>* traits = [rc.traits mutableCopy];

NSObject *prevId = [traits objectForKey:@"userId"];
if(prevId == nil) {
prevId =[traits objectForKey:@"id"];
}
NSObject *prevId = previousId ?: [traits objectForKey:@"userId"] ?: [traits objectForKey:@"id"] ?: self.anonymousId;

traits[@"id"] = newId;
traits[@"userId"] = newId;
Expand Down