Skip to content

Commit

Permalink
chore: conflicts lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
cisse21 committed Feb 18, 2025
1 parent 8a2bde0 commit 801559c
Show file tree
Hide file tree
Showing 18 changed files with 61 additions and 56 deletions.
1 change: 0 additions & 1 deletion integration_test/tracing/tracing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import (
"github.com/rudderlabs/rudder-server/gateway/response"
"github.com/rudderlabs/rudder-server/jobsdb"
"github.com/rudderlabs/rudder-server/jsonrs"
"github.com/rudderlabs/rudder-server/processor/transformer"
"github.com/rudderlabs/rudder-server/runner"
"github.com/rudderlabs/rudder-server/testhelper/backendconfigtest"
"github.com/rudderlabs/rudder-server/testhelper/health"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import (

backendconfig "github.com/rudderlabs/rudder-server/backend-config"
"github.com/rudderlabs/rudder-server/jobsdb"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/jsonrs"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/runner"
"github.com/rudderlabs/rudder-server/testhelper/health"
"github.com/rudderlabs/rudder-server/testhelper/transformertest"
Expand Down
6 changes: 3 additions & 3 deletions integration_test/warehouse/warehouse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1793,7 +1793,7 @@ func TestDestinationTransformation(t *testing.T) {
})
require.NoError(t, err)

var transformerEvents []transformer.TransformerEvent
var transformerEvents []types.TransformerEvent
err = jsonrs.Unmarshal([]byte(b.String()), &transformerEvents)
require.NoError(t, err)

Expand Down Expand Up @@ -1923,7 +1923,7 @@ func TestDestinationTransformation(t *testing.T) {
})
require.NoError(t, err)

var transformerEvents []transformer.TransformerEvent
var transformerEvents []types.TransformerEvent
err = jsonrs.Unmarshal([]byte(b.String()), &transformerEvents)
require.NoError(t, err)

Expand Down Expand Up @@ -2047,7 +2047,7 @@ func TestDestinationTransformation(t *testing.T) {
})
require.NoError(t, err)

var transformerEvents []transformer.TransformerEvent
var transformerEvents []types.TransformerEvent
err = jsonrs.Unmarshal([]byte(b.String()), &transformerEvents)
require.NoError(t, err)

Expand Down
2 changes: 1 addition & 1 deletion processor/consent.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"github.com/samber/lo"

backendconfig "github.com/rudderlabs/rudder-server/backend-config"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/jsonrs"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/utils/misc"
)

Expand Down
1 change: 1 addition & 0 deletions processor/events_response.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/rudderlabs/rudder-server/jobsdb"
"github.com/rudderlabs/rudder-server/jsonrs"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/utils/misc"
)

Expand Down
2 changes: 1 addition & 1 deletion processor/integrations/integrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (

"github.com/rudderlabs/rudder-go-kit/stats"
backendconfig "github.com/rudderlabs/rudder-server/backend-config"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/jsonrs"
"github.com/rudderlabs/rudder-server/processor/types"
"github.com/rudderlabs/rudder-server/utils/misc"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package destination_transformer
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"net/http"
Expand All @@ -12,6 +11,8 @@ import (
"sync"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

obskit "github.com/rudderlabs/rudder-observability-kit/go/labels"

"github.com/cenkalti/backoff"
Expand Down Expand Up @@ -174,7 +175,7 @@ func (d *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
err error
)

rawJSON, err = json.Marshal(data)
rawJSON, err = jsonrs.Marshal(data)
if err != nil {
panic(err)

Check warning on line 180 in processor/internal/transformer/destination_transformer/destination_transformer.go

View check run for this annotation

Codecov / codecov/patch

processor/internal/transformer/destination_transformer/destination_transformer.go#L180

Added line #L180 was not covered by tests
}
Expand Down Expand Up @@ -207,7 +208,7 @@ func (d *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
case http.StatusOK:
integrations.CollectIntgTransformErrorStats(respData)

err = json.Unmarshal(respData, &transformerResponses)
err = jsonrs.Unmarshal(respData, &transformerResponses)
// This is returned by our JS engine so should be parsable
// Panic the processor to avoid replays
if err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package destination_transformer_test

import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
Expand All @@ -13,6 +12,8 @@ import (
"testing"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"

Expand Down Expand Up @@ -40,7 +41,7 @@ type fakeTransformer struct {

func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
var reqBody []types.TransformerEvent
require.NoError(t.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(t.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

t.requests = append(t.requests, reqBody)

Expand All @@ -63,7 +64,7 @@ func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(t.t, json.NewEncoder(w).Encode(responses))
require.NoError(t.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endlessLoopTransformer struct {
Expand All @@ -83,7 +84,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
elt.retryCount++

var reqBody []types.TransformerEvent
require.NoError(elt.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(elt.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -105,7 +106,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
w.Header().Set("apiVersion", strconv.Itoa(elt.apiVersion))
}

require.NoError(elt.t, json.NewEncoder(w).Encode(responses))
require.NoError(elt.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endpointTransformer struct {
Expand All @@ -122,7 +123,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)
}

var reqBody []types.TransformerEvent
require.NoError(et.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(et.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -137,7 +138,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(et.t, json.NewEncoder(w).Encode(responses))
require.NoError(et.t, jsonrs.NewEncoder(w).Encode(responses))
}

func TestDestinationTransformer(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ package trackingplan_validation
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"strconv"
"sync"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

obskit "github.com/rudderlabs/rudder-observability-kit/go/labels"

"github.com/cenkalti/backoff"
Expand Down Expand Up @@ -161,7 +162,7 @@ func (t *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
err error
)

rawJSON, err = json.Marshal(data)
rawJSON, err = jsonrs.Marshal(data)
if err != nil {
panic(err)

Check warning on line 167 in processor/internal/transformer/trackingplan_validation/trackingplan_validation.go

View check run for this annotation

Codecov / codecov/patch

processor/internal/transformer/trackingplan_validation/trackingplan_validation.go#L167

Added line #L167 was not covered by tests
}
Expand Down Expand Up @@ -227,7 +228,7 @@ func (t *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
switch statusCode {
case http.StatusOK:
integrations.CollectIntgTransformErrorStats(respData)
err = json.Unmarshal(respData, &transformerResponses)
err = jsonrs.Unmarshal(respData, &transformerResponses)
// This is returned by our JS engine so should be parsable
// Panic the processor to avoid replays
if err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package trackingplan_validation_test

import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
Expand All @@ -13,6 +12,8 @@ import (
"testing"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"

Expand All @@ -39,7 +40,7 @@ type fakeTransformer struct {

func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
var reqBody []types.TransformerEvent
require.NoError(t.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(t.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

t.requests = append(t.requests, reqBody)

Expand All @@ -62,7 +63,7 @@ func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(t.t, json.NewEncoder(w).Encode(responses))
require.NoError(t.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endlessLoopTransformer struct {
Expand All @@ -82,7 +83,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
elt.retryCount++

var reqBody []types.TransformerEvent
require.NoError(elt.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(elt.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -104,7 +105,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
w.Header().Set("apiVersion", strconv.Itoa(elt.apiVersion))
}

require.NoError(elt.t, json.NewEncoder(w).Encode(responses))
require.NoError(elt.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endpointTransformer struct {
Expand All @@ -121,7 +122,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)
}

var reqBody []types.TransformerEvent
require.NoError(et.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(et.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -136,7 +137,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(et.t, json.NewEncoder(w).Encode(responses))
require.NoError(et.t, jsonrs.NewEncoder(w).Encode(responses))
}

func TestTrackingPlanValidator(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ import (
"sync"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

obskit "github.com/rudderlabs/rudder-observability-kit/go/labels"

"github.com/cenkalti/backoff/v4"
jsoniter "github.com/json-iterator/go"
"github.com/samber/lo"

"github.com/rudderlabs/rudder-go-kit/config"
Expand All @@ -30,8 +31,6 @@ import (
reportingtypes "github.com/rudderlabs/rudder-server/utils/types"
)

var json = jsoniter.ConfigCompatibleWithStandardLibrary

type Opt func(*Client)

func WithClient(client transformerclient.Client) Opt {
Expand Down Expand Up @@ -193,7 +192,7 @@ func (u *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
err error
)

rawJSON, err = json.Marshal(data)
rawJSON, err = jsonrs.Marshal(data)
if err != nil {
panic(err)

Check warning on line 197 in processor/internal/transformer/user_transformer/user_transformer.go

View check run for this annotation

Codecov / codecov/patch

processor/internal/transformer/user_transformer/user_transformer.go#L197

Added line #L197 was not covered by tests
}
Expand Down Expand Up @@ -259,7 +258,7 @@ func (u *Client) sendBatch(ctx context.Context, url string, labels types.Transfo
switch statusCode {
case http.StatusOK:
integrations.CollectIntgTransformErrorStats(respData)
err = json.Unmarshal(respData, &transformerResponses)
err = jsonrs.Unmarshal(respData, &transformerResponses)
// This is returned by our JS engine so should be parsable
// Panic the processor to avoid replays
if err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package user_transformer_test

import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
Expand All @@ -14,6 +13,8 @@ import (
"testing"
"time"

"github.com/rudderlabs/rudder-server/jsonrs"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
Expand Down Expand Up @@ -41,7 +42,7 @@ type fakeTransformer struct {

func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
var reqBody []types.TransformerEvent
require.NoError(t.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(t.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

t.requests = append(t.requests, reqBody)

Expand All @@ -64,7 +65,7 @@ func (t *fakeTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request) {

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(t.t, json.NewEncoder(w).Encode(responses))
require.NoError(t.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endlessLoopTransformer struct {
Expand All @@ -84,7 +85,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
elt.retryCount++

var reqBody []types.TransformerEvent
require.NoError(elt.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(elt.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -106,7 +107,7 @@ func (elt *endlessLoopTransformer) ServeHTTP(w http.ResponseWriter, r *http.Requ
w.Header().Set("apiVersion", strconv.Itoa(elt.apiVersion))
}

require.NoError(elt.t, json.NewEncoder(w).Encode(responses))
require.NoError(elt.t, jsonrs.NewEncoder(w).Encode(responses))
}

type endpointTransformer struct {
Expand All @@ -123,7 +124,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)
}

var reqBody []types.TransformerEvent
require.NoError(et.t, json.NewDecoder(r.Body).Decode(&reqBody))
require.NoError(et.t, jsonrs.NewDecoder(r.Body).Decode(&reqBody))

responses := make([]types.TransformerResponse, len(reqBody))

Expand All @@ -138,7 +139,7 @@ func (et *endpointTransformer) ServeHTTP(w http.ResponseWriter, r *http.Request)

w.Header().Set("apiVersion", strconv.Itoa(reportingtypes.SupportedTransformerApiVersion))

require.NoError(et.t, json.NewEncoder(w).Encode(responses))
require.NoError(et.t, jsonrs.NewEncoder(w).Encode(responses))
}

func TestUserTransformer(t *testing.T) {
Expand Down
Loading

0 comments on commit 801559c

Please sign in to comment.