Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowpipe streaming #5110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: snowpipe streaming #5110

wants to merge 2 commits into from

Conversation

achettyiitr
Copy link
Member

Description

  • Integrated new destination Snowpipe Streaming as part of async destination.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 8 times, most recently from 68163a6 to 5607206 Compare September 23, 2024 08:53
@achettyiitr achettyiitr marked this pull request as draft September 23, 2024 20:02
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 5 times, most recently from 444da09 to f569ead Compare September 23, 2024 23:36
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 78.23470% with 217 lines in your changes missing coverage. Please review.

Project coverage is 74.22%. Comparing base (18c102f) to head (91dedc5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...syncdestinationmanager/snowpipestreaming/upload.go 68.78% 44 Missing and 15 partials ⚠️
...yncdestinationmanager/snowpipestreaming/channel.go 64.18% 36 Missing and 17 partials ⚠️
...ncdestinationmanager/snowpipestreaming/discards.go 77.02% 12 Missing and 5 partials ⚠️
warehouse/utils/uploader.go 5.55% 17 Missing ⚠️
...manager/snowpipestreaming/testhelper/testhelper.go 62.96% 7 Missing and 3 partials ⚠️
.../asyncdestinationmanager/snowpipestreaming/poll.go 90.52% 8 Missing and 1 partial ⚠️
...destinationmanager/snowpipestreaming/apiadapter.go 90.36% 6 Missing and 2 partials ⚠️
...estinationmanager/snowpipestreaming/uploadstats.go 82.92% 6 Missing and 1 partial ⚠️
...yncdestinationmanager/snowpipestreaming/columns.go 72.72% 4 Missing and 2 partials ⚠️
...er/snowpipestreaming/internal/api/createchannel.go 76.00% 4 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5110      +/-   ##
==========================================
+ Coverage   73.24%   74.22%   +0.98%     
==========================================
  Files         424      445      +21     
  Lines       59960    60942     +982     
==========================================
+ Hits        43918    45236    +1318     
+ Misses      13585    13155     -430     
- Partials     2457     2551      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Stale and removed Stale labels Oct 15, 2024
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 5 times, most recently from 788f64d to d44d456 Compare October 28, 2024 08:51
@achettyiitr achettyiitr marked this pull request as ready for review October 28, 2024 08:52
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 3 times, most recently from 74e9353 to 0ccab91 Compare October 28, 2024 10:33
@rudderlabs rudderlabs deleted a comment from github-actions bot Oct 28, 2024
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 3 times, most recently from 7de6896 to 4fb264b Compare October 29, 2024 09:20
@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 2 times, most recently from edd1d39 to 958a6b2 Compare November 1, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant