Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: jobsdb flaky test #5197

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: jobsdb flaky test #5197

merged 2 commits into from
Oct 14, 2024

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Oct 14, 2024

Description

Missed teardown in one of the tests. That was causing jobsdb test suite to fail. This fixes that.

Linear Ticket

Resolves PIPE-1619

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth marked this pull request as ready for review October 14, 2024 11:48
@Sidddddarth Sidddddarth enabled auto-merge (squash) October 14, 2024 11:49
@Sidddddarth Sidddddarth changed the base branch from master to release/1.36.x October 14, 2024 11:54
@Sidddddarth Sidddddarth merged commit 192025a into release/1.36.x Oct 14, 2024
61 of 62 checks passed
@Sidddddarth Sidddddarth deleted the chore.jobsdbFlakyTest branch October 14, 2024 12:06
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/1.36.x@f305282). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.36.x    #5197   +/-   ##
=================================================
  Coverage                  ?   73.09%           
=================================================
  Files                     ?      439           
  Lines                     ?    51238           
  Branches                  ?        0           
=================================================
  Hits                      ?    37450           
  Misses                    ?    11341           
  Partials                  ?     2447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants