Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimisations - jobsdb queries #5215

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Oct 22, 2024

Description

some small jobsdb optimisations.
Making fewer queries where possible in jobsdb background operations(checkIfFullDSInTx, checkIfMigrateDS)

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth force-pushed the exp.jobsdbOptimisations branch 3 times, most recently from 52427e4 to 76255a0 Compare October 22, 2024 06:49
@Sidddddarth Sidddddarth changed the title chore: one query to check ds eligibility for migration chore: low hanging fruits - jobsdb queries Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 77.83505% with 43 lines in your changes missing coverage. Please review.

Project coverage is 73.30%. Comparing base (6abcedd) to head (3743bf6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
jobsdb/jobsdb.go 75.21% 22 Missing and 7 partials ⚠️
jobsdb/migration.go 81.81% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5215      +/-   ##
==========================================
+ Coverage   73.27%   73.30%   +0.02%     
==========================================
  Files         424      424              
  Lines       59960    60024      +64     
==========================================
+ Hits        43936    43998      +62     
- Misses      13559    13562       +3     
+ Partials     2465     2464       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth changed the title chore: low hanging fruits - jobsdb queries chore: optimisations - jobsdb queries Oct 22, 2024
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
Copy link
Member

@cisse21 cisse21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants