-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include commas in the profile size, handle failure case of profile more than 500kB in size #5241
Conversation
…le more than 5mb in size
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.38.x #5241 +/- ##
==================================================
+ Coverage 73.40% 73.58% +0.18%
==================================================
Files 424 425 +1
Lines 60243 59965 -278
==================================================
- Hits 44221 44126 -95
+ Misses 13578 13373 -205
- Partials 2444 2466 +22 ☔ View full report in Codecov by Sentry. |
router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go
Show resolved
Hide resolved
@@ -333,6 +338,15 @@ func (kbu *KlaviyoBulkUploader) Upload(asyncDestStruct *common.AsyncDestinationS | |||
return kbu.generateKlaviyoErrorOutput("Error while parsing JSON.", err, importingJobIDs, destinationID) | |||
} | |||
profileStructure := kbu.ExtractProfile(input) | |||
// if profileStructure length is more than 5 mb, throw an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// if profileStructure length is more than 5 mb, throw an error | |
// if profileStructure length is more than 500 kB, throw an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go
Show resolved
Hide resolved
…in the go-deps group (#5287)
Description
On debugging for the issue, we came across the two pointers addressed here.
Linear Ticket
Related to INT-2820, INT-2840
Security