-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include commas in the profile size, handle failure case of profile more than 500kB in size #5241
base: master
Are you sure you want to change the base?
Conversation
…le more than 5mb in size
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5241 +/- ##
==========================================
+ Coverage 73.24% 73.25% +0.01%
==========================================
Files 424 424
Lines 59960 59978 +18
==========================================
+ Hits 43918 43938 +20
+ Misses 13585 13579 -6
- Partials 2457 2461 +4 ☔ View full report in Codecov by Sentry. |
router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests and also add ratelimits in HTTP client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be handling them now in separate PRs, this PR is mainly a followup to a reported issue
Description
On debugging for the issue, we came across the two pointers addressed here.
Linear Ticket
Related to INT-2820, INT-2840
Security