Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oauth v2 stats refactor #5262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Nov 4, 2024

Description

The way in which stats are written is not easily readable. Through this PR, we are trying to make the stat emission in oauthv2 module a bit more developer friendly and readable

Linear Ticket

Resolves INT-2744

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

) (int, *AuthResponse, error) {
actionType := strings.Join(strings.Fields(strings.ToLower(logTypeName)), "_")
Copy link
Contributor Author

@sanpj2292 sanpj2292 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference

> strings.Join(strings.Fields(strings.ToLower("Refresh Token")), "_")
refresh_token

@sanpj2292 sanpj2292 self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (2aae3ec) to head (d1692d2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
services/oauth/v2/oauth.go 94.64% 3 Missing ⚠️
services/oauth/v2/utils.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         424      424           
  Lines       59967    59983   +16     
=======================================
+ Hits        43898    43911   +13     
- Misses      13606    13609    +3     
  Partials     2463     2463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant