feat: updated fb tests to pick version dynamically from config.js

rudderlabs · Nov 29, 2023 · 30a193f · 30a193f
1 parent 7de0c09
commit 30a193f
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 24 deletions.
diff --git a/src/v0/destinations/fb/config.js b/src/v0/destinations/fb/config.js
@@ -1,6 +1,8 @@
 const fs = require('fs');
 const path = require('path');
 
+const VERSION = 'v18.0';
+
 const getPath = (file) => path.resolve(__dirname, file);
 
 const baseMapping = JSON.parse(fs.readFileSync(getPath('./data/FbAppBasicMapping.json')));
@@ -20,6 +22,7 @@ const eventPropToTypeMapping = JSON.parse(
 );
 
 module.exports = {
+  VERSION,
   baseMapping,
   eventNameMapping,
   eventPropsMapping,

diff --git a/src/v0/destinations/fb/transform.js b/src/v0/destinations/fb/transform.js
@@ -14,6 +14,7 @@ const {
 } = require('../../util');
 
 const {
+  VERSION,
   baseMapping,
   eventNameMapping,
   eventPropsMapping,
@@ -250,7 +251,7 @@ function responseBuilderSimple(message, payload, destination) {
 
   // "https://graph.facebook.com/v13.0/644748472345539/activities"
 
-  const endpoint = `https://graph.facebook.com/v18.0/${appID}/activities`;
+  const endpoint = `https://graph.facebook.com/${VERSION}/${appID}/activities`;
 
   const response = defaultRequestConfig();
   response.endpoint = endpoint;

diff --git a/test/integrations/destinations/fb/dataDelivery/data.ts b/test/integrations/destinations/fb/dataDelivery/data.ts
@@ -1,3 +1,5 @@
+import { VERSION } from '../../../../../src/v0/destinations/fb/config';
+
 export const data = [
   {
     name: 'fb',
@@ -29,8 +31,7 @@ export const data = [
             },
             JSON: {},
           },
-          endpoint:
-            'https://graph.facebook.com/v18.0/RudderFbApp/activities?access_token=invalid_access_token',
+          endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities?access_token=invalid_access_token`,
           files: {},
           headers: {
             'x-forwarded-for': '1.2.3.4',
@@ -108,8 +109,7 @@ export const data = [
             },
             JSON: {},
           },
-          endpoint:
-            'https://graph.facebook.com/v18.0/RudderFbApp/activities?access_token=my_access_token',
+          endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities?access_token=my_access_token`,
           files: {},
           headers: {
             'x-forwarded-for': '1.2.3.4',
@@ -173,8 +173,7 @@ export const data = [
             },
             JSON: {},
           },
-          endpoint:
-            'https://graph.facebook.com/v18.0/1234567891234567/events?access_token=invalid_timestamp_correct_access_token',
+          endpoint: `https://graph.facebook.com/${VERSION}/1234567891234567/events?access_token=invalid_timestamp_correct_access_token`,
           files: {},
           headers: {
             'x-forwarded-for': '1.2.3.4',
@@ -239,8 +238,7 @@ export const data = [
           version: '1',
           type: 'REST',
           method: 'POST',
-          endpoint:
-            'https://graph.facebook.com/v18.0/1234567891234567/events?access_token=throttled_valid_access_token',
+          endpoint: `https://graph.facebook.com/${VERSION}/1234567891234567/events?access_token=throttled_valid_access_token`,
           headers: {},
           body: {
             JSON: {},
@@ -310,8 +308,7 @@ export const data = [
           version: '1',
           type: 'REST',
           method: 'POST',
-          endpoint:
-            'https://graph.facebook.com/v18.0/1234567891234567/events?access_token=invalid_account_id_valid_access_token',
+          endpoint: `https://graph.facebook.com/${VERSION}/1234567891234567/events?access_token=invalid_account_id_valid_access_token`,
           headers: {},
           body: {
             JSON: {},

diff --git a/test/integrations/destinations/fb/network.ts b/test/integrations/destinations/fb/network.ts
@@ -2,6 +2,7 @@ import { cloneDeep } from 'lodash';
 import { getFormData } from '../../../../src/adapters/network';
 import * as fbPixelNw from '../facebook_pixel/network';
 import { data } from './dataDelivery/data';
+import { VERSION } from '../../../../src/v0/destinations/fb/config';
 
 const fbPixelTcs = data
   .filter((_, i) => [2, 3, 4].includes(i))
@@ -19,7 +20,7 @@ const fbPixelTcs = data
 export const networkCallsData = [
   {
     httpReq: {
-      url: 'https://graph.facebook.com/v18.0/RudderFbApp/activities?access_token=invalid_access_token',
+      url: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities?access_token=invalid_access_token`,
       data: getFormData(data[0].input.request.body.body.FORM).toString(),
       params: { destination: 'fb' },
       headers: { 'User-Agent': 'RudderLabs' },
@@ -39,7 +40,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://graph.facebook.com/v18.0/RudderFbApp/activities?access_token=my_access_token',
+      url: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities?access_token=my_access_token`,
       data: getFormData(data[1].input.request.body.body.FORM).toString(),
       params: { destination: 'fb' },
       headers: { 'x-forwarded-for': '1.2.3.4', 'User-Agent': 'RudderLabs' },

diff --git a/test/integrations/destinations/fb/processor/data.ts b/test/integrations/destinations/fb/processor/data.ts
@@ -1,3 +1,5 @@
+import { VERSION } from '../../../../../src/v0/destinations/fb/config';
+
 export const data = [
   {
     name: 'fb',
@@ -618,7 +620,7 @@ export const data = [
                 },
                 JSON: {},
               },
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               files: {},
               headers: {
                 'x-forwarded-for': '1.2.3.4',
@@ -803,7 +805,7 @@ export const data = [
                 },
                 JSON: {},
               },
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               files: {},
               headers: {
                 'x-forwarded-for': '1.2.3.4',
@@ -893,7 +895,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -993,7 +995,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1177,7 +1179,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1277,7 +1279,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1377,7 +1379,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1551,7 +1553,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1731,7 +1733,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {
@@ -1831,7 +1833,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {
                 'x-forwarded-for': '2.3.4.5',
               },
@@ -2153,7 +2155,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://graph.facebook.com/v18.0/RudderFbApp/activities',
+              endpoint: `https://graph.facebook.com/${VERSION}/RudderFbApp/activities`,
               headers: {},
               params: {},
               body: {