Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor migrate test cases to new format #2630

Merged
merged 43 commits into from
Oct 18, 2023

Conversation

sanpj2292
Copy link
Contributor

Description of the change

Onboarding component tests

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

koladilip and others added 21 commits August 4, 2023 16:44
refactor: migrate af to component tests
refactor: migrate adobe_analytics to component tests
refactor: migrate fb_custom_audience to component tests
refactor: migrate heap to component tests
* refactor: migrate google sheets to component tests

* add router testcases
@sanpj2292 sanpj2292 requested review from sivashanmukh and a team as code owners September 19, 2023 07:41
@sanpj2292
Copy link
Contributor Author

Resolves INT-560

@sanpj2292 sanpj2292 changed the title Refactor.migrate test cases to new format chore: refactor migrate test cases to new format Sep 19, 2023
@ItsSudip ItsSudip requested review from a team as code owners September 19, 2023 10:09
koladilip
koladilip previously approved these changes Sep 29, 2023
Sai Sankeerth added 2 commits October 4, 2023 17:26
@sanpj2292 sanpj2292 requested a review from koladilip October 5, 2023 08:15
koladilip
koladilip previously approved these changes Oct 5, 2023
@sanpj2292 sanpj2292 requested a review from koladilip October 11, 2023 10:27
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.4% 91.4% Coverage
16.9% 16.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sanpj2292 sanpj2292 merged commit dca6ee0 into develop Oct 18, 2023
11 of 12 checks passed
@sanpj2292 sanpj2292 deleted the refactor.migrate-test-cases-to-new-format branch October 18, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants