feat: support page call in snapchat conversion #2688

anantjain45823 · 2023-10-05T11:50:24Z

Description of the change

Resolves INT-760
We will supporting page call in snapchat conversion similar to track call but with fixed event name

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

codecov · 2023-10-05T11:58:30Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ce47ec) 87.20% compared to head (2ea8283) 87.20%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2688   +/-   ##
========================================
  Coverage    87.20%   87.20%           
========================================
  Files          640      640           
  Lines        28461    28464    +3     
  Branches      6759     6760    +1     
========================================
+ Hits         24820    24823    +3     
  Misses        3314     3314           
  Partials       327      327

Files	Coverage Δ
src/v0/destinations/snapchat_conversion/config.js	`100.00% <100.00%> (ø)`
...c/v0/destinations/snapchat_conversion/transform.js	`93.13% <100.00%> (+0.06%)`	⬆️