Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard source ortto #2693

Merged
merged 8 commits into from
Oct 13, 2023
Merged

feat: onboard source ortto #2693

merged 8 commits into from
Oct 13, 2023

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Oct 6, 2023

Description of the change

Resolves INT-80

This PR onboards new source Ortto

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from a team and sivashanmukh as code owners October 6, 2023 12:19
@ujjwal-ab ujjwal-ab self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8bca3e4) 87.24% compared to head (49d6531) 87.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2693      +/-   ##
===========================================
+ Coverage    87.24%   87.26%   +0.02%     
===========================================
  Files          641      643       +2     
  Lines        28519    28574      +55     
  Branches      6780     6793      +13     
===========================================
+ Hits         24880    24935      +55     
  Misses        3310     3310              
  Partials       329      329              
Files Coverage Δ
src/v0/sources/ortto/transform.js 100.00% <100.00%> (ø)
test/integrations/sources/ortto/data.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/sources/ortto/transform.js Outdated Show resolved Hide resolved
src/v0/sources/ortto/transform.js Outdated Show resolved Hide resolved
src/v0/sources/ortto/transform.js Show resolved Hide resolved
@ujjwal-ab ujjwal-ab requested a review from ItsSudip October 12, 2023 15:19
ItsSudip
ItsSudip previously approved these changes Oct 13, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 13, 2023
@ujjwal-ab ujjwal-ab dismissed stale reviews from sanpj2292 and ItsSudip via 49d6531 October 13, 2023 07:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.2% 98.2% Coverage
0.0% 0.0% Duplication

@ujjwal-ab ujjwal-ab merged commit 4682268 into develop Oct 13, 2023
14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the feat.source-ortto branch January 14, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants