Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct handling of permission_denied error for GAEC & GARL #2699

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

sanpj2292
Copy link
Contributor

Description of the change

Proper handling of PERMISSION_DENIED error for Google Adwords Enhanced conversions and Google Adwords Remarketing Lists

Resolves INT-367

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sanpj2292 sanpj2292 self-assigned this Oct 9, 2023
@sanpj2292 sanpj2292 requested a review from a team as a code owner October 9, 2023 04:58
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b211840) 87.22% compared to head (c76c3a8) 87.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2699      +/-   ##
===========================================
- Coverage    87.22%   87.21%   -0.01%     
===========================================
  Files          640      640              
  Lines        28467    28467              
  Branches      6760     6760              
===========================================
- Hits         24829    24828       -1     
- Misses        3311     3312       +1     
  Partials       327      327              
Files Coverage Δ
...gle_adwords_enhanced_conversions/networkHandler.js 90.19% <100.00%> (ø)
...google_adwords_remarketing_lists/networkHandler.js 91.80% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 requested a review from a team October 9, 2023 10:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 merged commit eca3be1 into develop Oct 11, 2023
13 of 14 checks passed
@sanpj2292 sanpj2292 deleted the fix.nw-handle-garl-gaec branch October 11, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants