Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update duplicate verions in github release #2708

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

update duplicate verions in github release

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7461199) 87.28% compared to head (2f0f4ee) 87.28%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.46.0    #2708   +/-   ##
================================================
  Coverage            87.28%   87.28%           
================================================
  Files                  646      646           
  Lines                28574    28574           
  Branches              6785     6785           
================================================
  Hits                 24942    24942           
  Misses                3303     3303           
  Partials               329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik aashishmalik changed the base branch from develop to release/v1.46.0 October 18, 2023 07:29
@aashishmalik aashishmalik marked this pull request as ready for review October 18, 2023 07:29
@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners October 18, 2023 07:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aashishmalik aashishmalik merged commit be4c410 into release/v1.46.0 Oct 18, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the fix.dup-gitTag branch January 19, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants