Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added matchId check and timestamp conversion #2709

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

added matchId check and timestamp conversion

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aashishmalik aashishmalik requested review from a team as code owners October 11, 2023 07:18
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d681d5e) 87.21% compared to head (0f90f0d) 87.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2709      +/-   ##
===========================================
+ Coverage    87.21%   87.23%   +0.02%     
===========================================
  Files          640      641       +1     
  Lines        28470    28479       +9     
  Branches      6761     6768       +7     
===========================================
+ Hits         24831    24845      +14     
+ Misses        3312     3307       -5     
  Partials       327      327              
Files Coverage Δ
src/v0/destinations/campaign_manager/transform.js 92.85% <100.00%> (+5.47%) ⬆️
src/v0/destinations/campaign_manager/util.js 92.85% <92.85%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanpj2292
sanpj2292 previously approved these changes Oct 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@aashishmalik aashishmalik merged commit f49244d into develop Oct 11, 2023
12 checks passed
@sanpj2292 sanpj2292 deleted the fix.cm360-matchid branch October 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants