Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow support for full url from UI in freshsales and freshmarketer #2780

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Oct 31, 2023

Description of the change

Resolves INT-658

Allow support for full url from UI in freshsales and freshmarketer

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this Oct 31, 2023
@yashasvibajpai yashasvibajpai requested review from a team as code owners October 31, 2023 03:29
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (748b622) 87.14% compared to head (4d8ebc0) 87.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2780   +/-   ##
========================================
  Coverage    87.14%   87.14%           
========================================
  Files          766      766           
  Lines        28445    28445           
  Branches      6657     6657           
========================================
  Hits         24787    24787           
  Misses        3321     3321           
  Partials       337      337           
Files Coverage Δ
src/v0/destinations/freshmarketer/config.js 100.00% <100.00%> (ø)
src/v0/destinations/freshmarketer/utils.js 79.54% <100.00%> (ø)
src/v0/destinations/freshsales/config.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yashasvibajpai yashasvibajpai merged commit 570532c into develop Nov 3, 2023
@yashasvibajpai yashasvibajpai deleted the fix.fsales.fmarketer.domain.on.ui branch November 3, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants