Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move cdkV1 to cdkv2 component tests #2804

Merged
merged 8 commits into from
Nov 10, 2023
Merged

feat: move cdkV1 to cdkv2 component tests #2804

merged 8 commits into from
Nov 10, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

move cdkV1 to cdkv2 component tests

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners November 7, 2023 14:53
koladilip
koladilip previously approved these changes Nov 7, 2023
View reviewed changes
@aashishmalik aashishmalik force-pushed the feat.cdkV2-componentTests branch from 78a4d18 to e1c8db3 Compare November 7, 2023 16:32
@aashishmalik aashishmalik force-pushed the feat.cdkV2-componentTests branch from e1c8db3 to 9a8eb59 Compare November 7, 2023 18:19
@aashishmalik aashishmalik force-pushed the feat.cdkV2-componentTests branch from 9ac5340 to cd88e06 Compare November 10, 2023 08:17
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aashishmalik aashishmalik merged commit 195b48a into develop Nov 10, 2023
12 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the feat.cdkV2-componentTests branch February 11, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@koladilip koladilip koladilip approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823 anantjain45823 is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashishmalik @koladilip @mihir-4116