Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): onboard sprig destination #2857

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Nov 30, 2023

Description of the change

  • This pull request implements the integration of Sprig Destination within CDK v2. The Sprig integration introduces support for two key API calls: 'identify' and 'track'.
  • 'Identify' call: This creates a user within the Sprig dashboard. It allows for the creation of users, updating email addresses, and managing user attributes. Only the 'userId' is mandatory for a successful 'identify' call.
  • 'Track' call: This facilitates the creation of events within the Sprig dashboard. It requires both the 'userId' and the specific event name for accurate tracking.
  • we are using common endpoint for identify and track call.
  • for more info refer sprig api docs : https://docs.sprig.com/reference/post-user-v2-1

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36d3f25) 87.22% compared to head (a7bfce5) 87.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2857   +/-   ##
========================================
  Coverage    87.22%   87.22%           
========================================
  Files          787      788    +1     
  Lines        29163    29164    +1     
  Branches      6826     6826           
========================================
+ Hits         25438    25439    +1     
  Misses        3380     3380           
  Partials       345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir-4116 mihir-4116 requested a review from ujjwal-ab November 30, 2023 05:23
@mihir-4116 mihir-4116 changed the title fix(integrations): onboard sprig destination fix(INT-1037): onboard sprig destination Nov 30, 2023
@mihir-4116 mihir-4116 changed the title fix(INT-1037): onboard sprig destination fix(integrations): onboard sprig destination Nov 30, 2023
koladilip
koladilip previously approved these changes Nov 30, 2023
ItsSudip
ItsSudip previously approved these changes Dec 8, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mihir-4116 mihir-4116 merged commit ede22e3 into develop Dec 12, 2023
14 checks passed
@mihir-4116 mihir-4116 deleted the feat.sprig-cloud branch December 12, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants