Adding Bluecore integration #2963
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| } | ||
|
|
||
| let payload = constructPayload(message, MAPPING_CONFIG[category.name]); | ||
| let event = getValueFromMessage(message, 'event'); |
There was a problem hiding this comment.
identify does not have event field. Please check HTTP doc for identify
| * | ||
| * Handles order completed and checkout started types of specific events | ||
| */ | ||
| const handleOrder = (message, categoryToContent) => { |
There was a problem hiding this comment.
this implementation is specific to facebook, please edit according to bluecore needs
| currency, | ||
| position, | ||
| url, | ||
| image_url: imageUrl, |
There was a problem hiding this comment.
where is this coming from
| const useValue = valueFieldIdentifier === 'properties.value'; | ||
| const contentId = | ||
| message.properties?.product_id || message.properties?.sku || message.properties?.id; | ||
| const contentType = getContentType(message, 'product', categoryToContent); |
| }; | ||
|
|
||
| const handleSearch = (message) => { | ||
| const query = message?.properties?.query; |
There was a problem hiding this comment.
this is specific to facebook pixel
| } | ||
| return { | ||
| content_ids: contentIds, | ||
| content_category: getContentCategory(contentCategory), |
src/v0/destinations/bluecore/test.js
Outdated
| @@ -0,0 +1,35 @@ | |||
| const eventProcessor = require('./transform'); | |||
There was a problem hiding this comment.
please remove this file
| }, | ||
| { | ||
| "destKey": "customer.age", | ||
| "sourceKeys": "age", |
There was a problem hiding this comment.
[ traits , context.traits ]
| }, | ||
| { | ||
| "destKey": "customer.sex", | ||
| "sourceKeys": "sex", |
Dont need this file anymore.
Added more test cases.
|
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
…to bluecore-integration
…ransformer into bluecore-integration
|
|
we are using #3061 to continue on this. So closing this PR |
What are the changes introduced in this PR?
Adding bluecore integration.
Write a brief explainer on your code changes.
Followed standard procedure to add a destination and its test case.
What is the related Linear task?
https://linear.app/rudderstack/issue/INT-70/event-stream-destination-bluecore
resolves INT-70
Resolves INT-70
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.