-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust shopify upgrade to v2 #3924
base: develop
Are you sure you want to change the base?
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3924/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3924 +/- ##
========================================
Coverage 90.75% 90.76%
========================================
Files 622 624 +2
Lines 32516 32547 +31
Branches 7718 7723 +5
========================================
+ Hits 29511 29541 +30
- Misses 2749 2750 +1
Partials 256 256 ☔ View full report in Codecov by Sentry. |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Allure Test reports for this run are available at:
|
Allure Test reports for this run are available at:
|
1 similar comment
Allure Test reports for this run are available at:
|
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
upgradedToSourceTransformV2
infeatures.ts
upgradedToSourceTransformV2
nowWhat is the related Linear task?
Resolves INT-2899
Please explain the objectives of your changes below
To upgrade sources which are dependent on
query_parameters
to V2 while maintaining fallback code incase of major errorsAny changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Component test cases for sources run twice with 2 different feature.ts
upgradedToSourceTransformV2
values.Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
In case of both shopify and adjust input specification conversion is going to happen twice.
Example case:
Shopify gets v1 request (with upgradedToSourceTransformV2 = true and rudder-server is not upgraded yet) - rare case
v1 request is converted to v2 spec first and shopifyv2 implementation internally coverts v2 to v1 and uses the same v1 code.
This will be a temporary performance concern until we are happy with the stability of the deployment.
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.