feat: add redis support in shopify pixel for id stitching #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3957/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3957 +/- ##
===========================================
+ Coverage 90.76% 90.78% +0.02%
===========================================
Files 624 625 +1
Lines 32547 32594 +47
Branches 7723 7736 +13
===========================================
+ Hits 29541 29591 +50
+ Misses 2750 2747 -3
Partials 256 256 ☔ View full report in Codecov by Sentry. |
utsabc
reviewed
Jan 6, 2025
Co-authored-by: Utsab Chowdhury <[email protected]>
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
|
Allure Test reports for this run are available at:
|
krishna2020
reviewed
Jan 9, 2025
krishna2020
reviewed
Jan 9, 2025
src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
Outdated
Show resolved
Hide resolved
krishna2020
reviewed
Jan 9, 2025
src/v1/sources/shopify/webhookTransformations/serverSideTransform.js
Outdated
Show resolved
Hide resolved
* chore: add campaign object support in web pixel events * chore: add custom utm support
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
utsabc
previously approved these changes
Jan 15, 2025
|
@yashasvibajpai sonar coverage needs to be improved on new code |
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
|
utsabc
approved these changes
Jan 20, 2025
yashasvibajpai
added a commit
that referenced
this pull request
Jan 22, 2025
yashasvibajpai
added a commit
that referenced
this pull request
Jan 22, 2025
yashasvibajpai
added a commit
that referenced
this pull request
Jan 23, 2025
* feat: add redis support in shopify pixel for id stitching (#3957) * chore: pixelEventLabel for identifier events also * fix: redis await missing * fix: setProperty issue * fix: refactor basic code flow * chore: handle imports, await functions * chore: add pixel prefix for redis carttoken in shopify * chore: address comments * chore: add stat for serverside missing cart token * chore: add unit test for utm param extractfunction --------- Co-authored-by: Utsab Chowdhury <[email protected]>
yashasvibajpai
added a commit
that referenced
this pull request
Jan 23, 2025
…ce (#3980) * feat: add redis support in shopify pixel for id stitching * chore: update redis set structure * chore: update attribute name Co-authored-by: Utsab Chowdhury <[email protected]> * fix: stitched events through redis in pixel * fix: stitched events through redis in pixel * fix: stitched events through redis in pixel * chore: add tests * chore: add campaign object support in web pixel events (#3973) * chore: add campaign object support in web pixel events * chore: add custom utm support * chore: address comments * feat: add DATA WAREHOUSE to intg object in shopify pixel * feat: add DATA WAREHOUSE json path handling for some providers * chore: update json structure to be event specific in shopify * chore: add test * chore: add testx2 * chore: resolve conflict * chore: address comments, refactor wh changes * chore: refactor * chore: resolve conflicts * chore: fix test * feat: add redis support in shopify pixel for id stitching (#3957) * feat: add redis support in shopify pixel for id stitching (#3957) * chore: fix redis test * chore: pixelEventLabel for identifier events also * fix: redis await missing * fix: setProperty issue * fix: refactor basic code flow * chore: handle imports, await functions * chore: add pixel prefix for redis carttoken in shopify * chore: address comments * chore: add stat for serverside missing cart token * chore: add unit test for utm param extractfunction * chore: fix sonar issues in wh index js --------- Co-authored-by: Utsab Chowdhury <[email protected]>
yashasvibajpai
added a commit
that referenced
this pull request
Jan 23, 2025
* feat: add redis support in shopify pixel for id stitching (#3957) * feat: add redis support in shopify pixel for id stitching (#3957) * chore: update order cancelled, property datatypes * chore: pixelEventLabel for identifier events also * fix: redis await missing * fix: setProperty issue * fix: refactor basic code flow * chore: handle imports, await functions * chore: update order cancelled test --------- Co-authored-by: Utsab Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Add redis support in shopify pixel for id stitching
What is the related Linear task?
Resolves INT-3056
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.