avm2: Add warning about method ordering on int and uint

ruffle-rs · Feb 8, 2025 · a298358 · a298358
1 parent 6231421
commit a298358
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/core/src/avm2/globals/int.as b/core/src/avm2/globals/int.as
@@ -69,6 +69,9 @@ package {
 
         // These methods are unreachable. Calling a method on an Integer will
         // lookup and call the method using `Number`'s vtable, not `int`'s.
+        // IMPORTANT: these methods must be kept in the same order as they are
+        // declared in Number.as. Otherwise the bytecode optimizer may emit a
+        // call to the wrong method when calling on an `int` or `uint`.
         AS3 native function toExponential(digits:* = 0):String;
 
         AS3 native function toFixed(digits:* = 0):String;

diff --git a/core/src/avm2/globals/uint.as b/core/src/avm2/globals/uint.as
@@ -69,6 +69,9 @@ package {
 
         // These methods are unreachable. Calling a method on an Integer will
         // lookup and call the method using `Number`'s vtable, not `uint`'s.
+        // IMPORTANT: these methods must be kept in the same order as they are
+        // declared in Number.as. Otherwise the bytecode optimizer may emit a
+        // call to the wrong method when calling on an `int` or `uint`.
         AS3 native function toExponential(digits:* = 0):String;
 
         AS3 native function toFixed(digits:* = 0):String;