avm2: Port Vector classes to AS #19393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-vector-as
branch
from
4c35681 to
bb3980e
Compare
kjarosh
added
A-avm2
Lord-McSweeney
added
the
waiting-on-review
Lord-McSweeney
changed the title
adrian17
approved these changes
Feb 4, 2025
| @@ -279,6 +284,13 @@ fn rust_method_name_and_path( | |||
| let name = resolve_multiname_name(abc, trait_name).to_string(); | |||
|
|
|||
| path += &flash_to_rust_string(&name, false, "::"); | |||
|
|
|||
| match &trait_.kind { | |||
| TraitKind::Getter { .. } => flash_method_path += "get ", | |||
There was a problem hiding this comment.
To be sure, what was this added for?
There was a problem hiding this comment.
The changes around naming were to have correct method names in stack traces. Without the two changes, the DisplayObject blendMode setter would display as flash.display::DisplayObject/flash::display::DisplayObject::blendMode(). Now it displays as flash.display::DisplayObject/set blendMode(), matching FP.
Lord-McSweeney
removed
the
waiting-on-review
added 9 commits
February 4, 2025 16:35
This implements all the necessary machinery to do so with the rest of the Vector$ classes
Lord-McSweeney
force-pushed
the
avm2-vector-as
branch
from
57b258d to
a29c5f7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks porting Number, uint, and int to AS