avm1: Don't use a static AvmString for AVM1 array's length property
#19480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
approved these changes
Feb 12, 2025
Lord-McSweeney
force-pushed
the
avm1-array-builder
branch
from
f0f4b72 to
98c1a43
Compare
`ArrayObject` construction now requires an activation, so add `ArrayObjectBuilder` to simplify the process: it allows grabbing what we need from the activation (the interned `length` property name, and the array prototype) without running afoul of the borrow checker.
moulins
force-pushed
the
avm1-array-builder
branch
from
98c1a43 to
2eb05eb
Compare
|
Labels, please! 🥺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayObjectconstruction now requires an activation, so addArrayObjectBuilderto simplify the process: it allows grabbing what we need from the activation (the internedlengthproperty name, and the array prototype) without running afoul of the borrow checker.