-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved UnicodeFontHandler to background scripts #11
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
import * as AddonSettings from "/common/modules/AddonSettings/AddonSettings.js"; | ||
import * as BrowserCommunication from "/common/modules/BrowserCommunication/BrowserCommunication.js"; | ||
import { isMobile } from "./MobileHelper.js"; | ||
import { isMobile } from "/common/modules/MobileHelper.js"; | ||
|
||
import { COMMUNICATION_MESSAGE_TYPE } from "/common/modules/data/BrowserCommunicationTypes.js"; | ||
import { caseIds, fontIds, fonts } from "/common/modules/data/Fonts.js"; | ||
|
@@ -207,6 +207,7 @@ function applySettings(unicodeFont) { | |
* @returns {void} | ||
*/ | ||
export async function init() { | ||
// Remove once https://bugzilla.mozilla.org/show_bug.cgi?id=1595822 is fixed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, this comment comments a
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, that bug is about implementing the WebExtension context menu API in Firefox for Android. |
||
if (await isMobile()) { | ||
return; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,6 +87,7 @@ <h1 data-i18n="">Unicode autocorrection</h1> | |
</ul> | ||
</section> | ||
|
||
<!-- Remove "mobile-incompatible" once https://bugzilla.mozilla.org/show_bug.cgi?id=1595822 is fixed --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here… If so, that’s of course not the proper way to do so. Because this add-on may (as for the auto-correction part, at least), run fine on Firefox for Android (Fenix, if they allow all add-ons in a future version). So we need a different There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above. The context menu does not currently work in the compose window of Thunderbird because of bug 1656506, although it does not need to be disabled and it looks like this may be fixed by bug 1670832. |
||
<section class="mobile-incompatible"> | ||
<ul> | ||
<h1 data-i18n="">Context menu</h1> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, let’s hope these design systems don’t diverge too much… 🙃