Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated autocorrect to not match version numbers #43

Merged
merged 5 commits into from
Jun 26, 2021
Merged

Conversation

tdulcet
Copy link
Collaborator

@tdulcet tdulcet commented May 17, 2021

  • Fixes Version numbers should not be replaced as  #40
  • Improved performance.
    • Improved toggle case performance by not both upper and lowercaseing every letter.
    • Replaced for loops with map().
  • Partially implemented doc: add AMO & Readme description #21 (comment).
  • The <all_urls> permission is not needed for Thunderbird. The compose permission replaces it. While it is not needed for the compose window, it is needed when viewing webpages in TB, so I reverted this change.
  • More minor bug fixes:
    • The ampersand is a special character in the menu titles and needs to be escaped for the live previews.
    • Fixed errors when context menu is opened with non-editable text selected.
  • Fixed indentation on options page. The headings should not have been in the list. (I messed this up in Added Unicode autocorrect and font conversion #2.)
  • Minor ESLint fix.
  • Use the localized extension name in Chrome (see Added screenshots #45).
  • Removed use of deprecated substr() method.

@tdulcet tdulcet requested a review from rugk May 17, 2021 08:14
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor code-style stuff.

@tdulcet tdulcet requested a review from rugk May 21, 2021 14:06
rugk
rugk previously approved these changes May 21, 2021
@rugk
Copy link
Owner

rugk commented May 21, 2021

The <all_urls> permission is not needed for Thunderbird. The compose permission replaces it.

Note we also need to adjust the permissions documentation then now. (i.e. <all_urls>), it could note an “except for Thunderbird”, e.g. If you wanna do so, feel free to do it. 😃

@tdulcet
Copy link
Collaborator Author

tdulcet commented May 22, 2021

Note we also need to adjust the permissions documentation then now. (i.e. <all_urls>), it could note an “except for Thunderbird”, e.g. If you wanna do so, feel free to do it. 😃

OK, I can do the English at least.

@tdulcet tdulcet requested a review from rugk May 22, 2021 07:39
@tdulcet tdulcet mentioned this pull request May 22, 2021
@tdulcet
Copy link
Collaborator Author

tdulcet commented Jun 22, 2021

please ping me/request a review if I should forget it

@rugk - It has been over a month, so I am just kindly pinging you...

OK, I can do the English at least.

I decided to revert this change (see edit to first post above), so I also removed my commit which updated the permissions documentation.

@rugk rugk merged commit 23c09b9 into main Jun 26, 2021
@rugk rugk deleted the version-numbers branch June 26, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version numbers should not be replaced as
2 participants