Challenge 1 completted, and naming convention

CONTRIBUTING.md

@@ -18,4 +18,10 @@ You could fork the project and then open PR to the upstream project. Here are co
 * [How to make a pull request on an open source project](https://www.youtube.com/watch?v=8A4TsoXJOs8)
 
 ### Git, branches, naming, strategy...
-TBD
+The branches created for contributing to a challenge should follow this naming convention
+
+```
+challenge-$CHALLENGE_NUMBRE/$CONTRIBUTOR_NAME
+# Example
+challenge-1/asavov
+```

PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,6 @@
 # Pull Request checklist
 
+* [ ] My branch follows the naming convention e.g. "challenge-1/asavov"
 * [ ] I am contributing single HTML file, no folders, no any other external files even icons or images. - [Image CDN](https://placehold.co/)
 * [ ] My HTML is 100% valid - [HTML Validator](https://validator.w3.org/#validate_by_input)
 * [ ] My code is semantic (HTML/CSS/JS)

src/content/challenges/1.mdx

@@ -54,15 +54,16 @@ Not available
 <DocumentPreview content={rpetrovDocument} index="1" fileName="rpetrov.html" />
 
 ### Discussion topics
-TBA
-
-### Conclusions
-TBA
+- Type scales in typography and UI design common rules
+- Collapsing margins
+- Different CSS resets approaches
+- Utility classes vs no classes
+- Semantic meaning of figure, picture, q, blockqute, time
 
 <Winner>
-  <em>TBA</em>
+  <em>gdespolov</em>
 </Winner>
 
 <MVP>
-  <em>TBA</em>
+  <em>gdespolov</em>
 </MVP>

src/content/challenges/2.mdx

@@ -44,9 +44,6 @@ import rpetrovDocument from '/challenge-contributions/2/rpetrov.html?url&raw';
 ### Discussion topics
 TBA
 
-### Conclusions
-TBA
-
 <Winner>
   <em>TBA</em>
 </Winner>

src/pages/contribution-guide.astro

@@ -58,6 +58,14 @@ import { SITE_TITLE, SITE_DESCRIPTION } from '@src/consts';
         <li><a href="https://www.youtube.com/watch?v=8lGpZkjnkt4">GitHub Pull Request in 100 Seconds - Git a FREE sticker</a></li>
         <li><a href="https://www.youtube.com/watch?v=8A4TsoXJOs8">How to make a pull request on an open source project</a></li>
       </p>
+
+      <h3>Git, branches, naming, strategy...</h3>
+
+      <p>The branches created for contributing to a challenge should follow this naming convention</p>
+
+      <p><code>challenge-$CHALLENGE_NUMBRE/$CONTRIBUTOR_NAME</code></p>
+
+      <p>For example: <code>challenge-1/asavov</code></p>
     </main>
   </body>
 </html>

src/pages/index.astro

@@ -54,7 +54,7 @@ import { SITE_TITLE, SITE_DESCRIPTION } from '@src/consts';
             <th>Wins</th>
             <th>MVP</th>
             <th>Suggested challenges</th>
-            <th>Total</th>
+            <th>Total (pts.)</th>
           </tr>
         </thead>
         <tbody>
@@ -67,10 +67,10 @@ import { SITE_TITLE, SITE_DESCRIPTION } from '@src/consts';
           </tr>
           <tr>
             <td>Georgi Despolov</td>
+            <td>1</td>
+            <td>1</td>
             <td>0</td>
-            <td>0</td>
-            <td>0</td>
-            <td>0</td>
+            <td>4</td>
           </tr>
           <tr>
             <td>Svetlin Markov</td>