Skip to content

Commit

Permalink
Upgrade docker and deployment to use node v12
Browse files Browse the repository at this point in the history
  • Loading branch information
Rumen Petrov committed Mar 27, 2024
1 parent b127f0d commit f8c5a95
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 7 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout your repository using git
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install, build, and upload your site
uses: withastro/action@v0
uses: withastro/action@v2
with:
# path: . # The root location of your Astro project inside the repository. (optional)
node-version: 18.18.0 # The specific version of Node that should be used to build your site. Defaults to 16. (optional)
package-manager: npm # The Node package manager that should be used to install dependencies and build your site. Automatically detected based on your lockfile. (optional)
# path: . # The root location of your Astro project inside the repository. (optional)
node-version: 20 # The specific version of Node that should be used to build your site. Defaults to 20. (optional)
# package-manager: pnpm@latest # The Node package manager that should be used to install dependencies and build your site. Automatically detected based on your lockfile. (optional)

deploy:
needs: build
Expand All @@ -36,4 +36,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v4
2 changes: 1 addition & 1 deletion Containerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:20
WORKDIR /var/www/app
COPY package*.json ./
RUN npm install
Expand Down
4 changes: 4 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
"name": "fe-hunger-games",
"type": "module",
"version": "0.0.1",
"engines": {
"node": "^20.x",
"npm": "^10.x"
},
"scripts": {
"dev": "astro dev",
"start": "astro dev",
Expand Down

0 comments on commit f8c5a95

Please sign in to comment.