RUN-17254 Prune non-existing pods from topology #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshaibi
changed the title
roir
reviewed
Apr 3, 2024
Comment on lines
+120
to
+132
| for i := range nodeTopology.Gpus { | ||
| nodeTopology.Gpus[i].Status.PodGpuUsageStatus = topology.PodGpuUsageStatusMap{} | ||
|
|
||
| // Remove non-existing pods from the allocation info | ||
| allocatingPodExists, err := isPodExist(c.kubeClient, nodeTopology.Gpus[i].Status.AllocatedBy.Pod, nodeTopology.Gpus[i].Status.AllocatedBy.Namespace) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to check if pod %s exists: %v", nodeTopology.Gpus[i].Status.AllocatedBy.Pod, err) | ||
| } | ||
|
|
||
| if !allocatingPodExists { | ||
| nodeTopology.Gpus[i].Status.AllocatedBy = topology.ContainerDetails{} | ||
| } | ||
| } |
There was a problem hiding this comment.
just a thought - in scale scenarios you could have 10000+ "gpus"
maybe we want to support it in a pool of goroutines, say 1 for each 100/1000 etc.
i'm not sure how much this section takes but it looked like it might be costly on scale.
if not - ignore.
if yes and you want to do in another jira - that's also ok open the jira and send me
There was a problem hiding this comment.
This section happens only upon initialization and is not part of the ongoing logic of the status-updater so I think we can start with that and improve if needed later on
roir
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.