RUN-20245 Support NodePool GPU Topology #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gshaibi
commented
Jul 15, 2024
gshaibi
commented
- private
- BaseTopology -> ClusterTopology
gshaibi
changed the title
noaamran
reviewed
Jul 16, 2024
deploy/fake-gpu-operator/values.yaml
Outdated
| gpuMemory: 11441 | ||
| nodePoolLabelKey: run.ai/simulated-gpu-node-pool | ||
| mig-strategy: mixed |
There was a problem hiding this comment.
why is it mig-strategy vs migStrategy?
There was a problem hiding this comment.
Oh thanks, my mistake
| // labelNode labels the node with required labels for the fake-gpu-operator to function. | ||
| func (p *NodeHandler) labelNode(node *v1.Node) error { | ||
| err := p.patchNodeLabels(node, map[string]interface{}{ | ||
| "nvidia.com/gpu.deploy.dcgm-exporter": "true", |
There was a problem hiding this comment.
Would it be helpful to make the labels consts?
iris-shain-runai
approved these changes
Jul 16, 2024
gshaibi
deleted the
shaibi/RUN-20245-support-gpu-topology-by-node-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.